-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dafny: New lexer for Dafny #1647
Conversation
Super excited for this! |
Any concerns with this PR? |
Thanks for your contribution @davidcok 🙇🏼 I don't have any exp. with Dafny 😅 but will try my best to review this MR. After the first scan of the doc, I can verify that the sample looks good to me. There are no existing counterparts on https://github.com/pygments/pygments so it might be good to port it over at a later stage. |
@dblessing could you kindly do the maintainer review, please? 🙏🏼 |
Hi, thanks for picking this up. Dafny has added some new keywords since this PR was opened. We would like to add them to this PR, if possible. |
What are the new keywords?
I created this PR but am not on the Dafny team anymore.
- David
… On Jul 15, 2021, at 12:00 PM, Matthias Schlaipfer ***@***.***> wrote:
Hi, thanks for picking this up. Dafny has added some new keywords since this PR was opened. We would like to add them to this PR, if possible.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1647 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABITDQFO6TFTTXRJYW5N2ADTX4A3VANCNFSM4US2OZ4A>.
|
The new keywords are |
@davidcok I've created a PR against your feature.dafny branch. I haven't tested it. If that looks fine, I think by simply accepting my PR this PR will be updated. |
Add keywords for and nameonly and remove indentation
@tancnle we've addressed your comments and made the changes to bring this PR up to speed with recent changes to Dafny. From our side this PR can be merged. Thanks! |
@dblessing Could you please review and merge when you have some time, please? 🙏🏼 |
@tancnle @dblessing - We're so close! I can taste it! :) Any chance of reviewing and merging soon? |
@robin-aws Unfortunately, I do not have merge right on this repo. Sorry. 😢 |
@mschlaipfer @davidcok @robin-aws Thank you for your patience and hard work on this one 🙇🏼 💯 |
And thank you @tancnle for the help! :) What is the release cadence for rouge these days? I noticed the first |
@robin-aws As needed. We can do another release in the near future. I don't want people to have to wait long for merged changes. |
Thanks @dblessing! Consider this a +1 for releasing soon then. The sooner we have a release the sooner I can pester downstream systems to pick it up so we really get the benefit! :) |
This PR creates a rouge lexer for the Dafny programming language
(https://github.com/dafny-lang/dafny)