Fix Crystal floor division becoming regex literals #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrmont
approved these changes
Dec 5, 2020
|
@rymiel Thanks for adding this. It will be included in the next release of Rouge that will come out on Tuesday or Wednesday of next week (depending on your time zone). In terms of its impact on regex literals, it looked good to me but, to be honest, the visual sample for Crystal is really lacking in coverage so it's difficult to tell. I'll open a separate PR that adds a more comprehensive set of examples (based on those in Python's Pygments syntax highlighting library). Thanks again! |
|
I do agree, I had to write a couple of short test snippets just to sanity
check myself, though a more complete and thought-out version would be great!
…On Sat, Dec 5, 2020, 06:35 Michael Camilleri ***@***.***> wrote:
@rymiel <https://github.com/rymiel> Thanks for adding this. It will be
included in the next release of Rouge that will come out on Tuesday or
Wednesday of next week (depending on your time zone).
In terms of its impact on regex literals, it looked good to me but, to be
honest, the visual sample for Crystal is really lacking in coverage so it's
difficult to tell. I'll open a separate PR that adds a more comprehensive
set of examples (based on those in Python's Pygments syntax highlighting
library). Thanks again!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1639 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM2PQC75IYWGRGWPL43O55LSTG2ALANCNFSM4UF5UMMQ>
.
|
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
Currently, Crystal's floor division operator (`//`) is not lexed properly when `:root` is the topmost state in the stack. Instead, Rouge lexs it as the regular division operator (`/`) followed by a regex literal. This commit adds `//` to the rule that matches `**` and other repeated operator characters. It also reorders some of these operators to ensure that they are matched correctly. Co-authored-by: Michael Camilleri <mike@inqk.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the crystal floor division operator
//is not lexed properly when:rootis the topmost thing on the stack (default state). It becomes a regular division followed by a regex literal. This literal will span multiple lines until met by another/, which can make large parts of a file become seemingly unformatted.This change adds
//as an operator next to**, as they seem similar. This shouldn't affect actual regex literals or empty regex literals (which are also//) though I haven't tested it much with real-code examples