Revert empty patterns in Ruby lexer #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stomar Thanks for reporting the error. This was a mistake on our part connected with some broader maintenance on the project. The changes have been reverted 🎉 |
jneen
approved these changes
Nov 9, 2020
|
@stomar This has been merged in and will be part of v3.25.0. That's scheduled for release later today (or tomorrow depending on your time zone). Thanks again! |
|
Great, thanks! |
stomar
added a commit
to stomar/www.ruby-lang.org
that referenced
this pull request
Dec 21, 2020
Remove restriction to rouge < 3.24.0 and update rouge. The bug in rouge 3.24.0 concerning syntax highlighting of regular expressions has been fixed in version 3.25.0, see * rouge-ruby/rouge#1618 * rouge-ruby/rouge#1624
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The maintenance changes in rouge-ruby#1548 resulted in updates to two rules in the Ruby lexer, one regarding regular expression flags and the other regarding heredoc strings. However, these patterns should not have been changed. The change in rouge-ruby#1548 was to prevent rules that matched an empty string unless they contained a 'predicate' of some sort. Both rules in the Ruby lexer contained such a predicate and so should not have been changed. This commit fixes that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maintenance changes in #1548 resulted in updates to two rules in the Ruby lexer, one regarding regular expression flags and the other regarding heredoc strings. However, these patterns should not have been changed. The change in #1548 was to prevent rules that matched an empty string unless they contained a 'predicate' of some sort. Both rules in the Ruby lexer contained such a predicate and so should not have been changed. This PR fixes that error.
This fixes #1618.