Ensure word break exists after keywords in Kotlin lexer #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1monw1 Thanks for reporting this. The problem seemed to have been introduced by a rule that added support for labels being used with certain keywords (including |
|
+1 from me. |
jneen
approved these changes
Nov 9, 2020
|
Thanks. Seems to work fine :) |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
Rouge will currently match identifiers in the Kotlin lexer that begin with certain keywords (such as `super`). This is because of a change in rouge-ruby#1496 that added a rule to support labels. That change should have updated the rule to end with a `\b` so as to ensure that identifiers that begin with the listed keywords are followed by a word break. This commit fixes that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rouge currently will match identifiers that begin with certain keywords (such as
super). This is because of a change in #1496 that added a rule to support labels. That change should have ensured that the rule ended with a\bto ensure that identifiers that begin with the listed keywords are followed by a word break. This PR fixes that mistake.It fixes #1608.