used 'Enumerator#with_index' to detect lineno. #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'tokens_in_line' -> 'line_tokens' The names of variables used as "line_tokens" in html_line_table and html_linewise files should be changed to match the names of those files.
|
+1 from me. @fumihumi which version of Ruby added this method? |
|
@jneen cc @pyrmont I used https://github.com/akr/all-ruby to check it. If you want to run it by hand, you can check it with the following command result: https://gist.github.com/fumihumi/d4966df51852a08b8807ba9ea0dd585b Thank you! |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
* used 'Enumerator#with_index' to detect lineno. * Changing variable names * 'tokens_in_line' -> 'line_tokens' The names of variables used as "line_tokens" in html_line_table and html_linewise files should be changed to match the names of those files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used 'Enumerator#with_index' to detect lineno.
before: Defined a variable called lineno to count up for each loop.
after: Fixed it.' Enumerator#with_index'.
Rouge::Formatters is often referenced by developers when creating Custom Formatters, so I think it should be written in a better Ruby way.
and fix block scope variable name.(Adjusted variable names to match those used in other files.)