Do not read ::class as opening a 'class' #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…revents pushing a :class. Fixes #1571
pyrmont
suggested changes
Sep 8, 2020
There was a problem hiding this comment.
@contradictioned Thanks for submitting a PR and I'm sorry that it took so long to get to it. I have a question below.
pyrmont
added
author-action
pyrmont
approved these changes
Sep 8, 2020
pyrmont
removed
the
author-action
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
Due to the way the Kotlin lexer treats the 'class' keyword, the use of the callable reference, `::class`, can result in the lexer moving into an incorrect state where it interprets `class` as beginning a class definition. This commit fixes that bug. Co-authored-by: Michael Camilleri <mike@inqk.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly find 'class' after the '::' operator and render as name. Prevents pushing a :class. Fixes #1571
I figured that this works. But please tell me if that is not the best way to do so :)