Add Lexer#with and Lexer.lookup_fancy #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fully backwards-compatible, so it should not be necessary to wait for 4.0 unless it's imminent (which maybe it should be...?) |
added 2 commits
July 21, 2020 00:43
These are overridden by any options set in the query parameters.
|
This one is still ready to go I think. I'm going to merge it if there aren't any objections. |
pyrmont
approved these changes
Sep 26, 2020
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
* add Lexer#with, for specifying options after initialization * split out Lexer.lookup_fancy from Lexer.find_fancy * rename additional_options -> default_options These are overridden by any options set in the query parameters. * provide a comment for Lexer#with Co-authored-by: http://jneen.net/ <jneen@jneen.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #1188.
These are necessary for modifying the options of a lexer. Currently
Lexer.find_fancyis a giant monolith, and there is no way to modify or default the lexer that is returned.Lexer#withallows for modifying the options after initialization, andLexer.lookup_fancy, which returns the lexer class and an options hash, allows for directly manipulating the options before initialization.