Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janet lexer #1558

Merged
merged 55 commits into from
Jul 5, 2020
Merged

Janet lexer #1558

merged 55 commits into from
Jul 5, 2020

Conversation

sogaiu
Copy link
Contributor

@sogaiu sogaiu commented Jun 29, 2020

This is some initial work on supporting Janet.

The lexer is based on the existing Clojure lexer.

@pyrmont pyrmont changed the title [Draft] Initial work on Janet support Janet lexer Jun 29, 2020
@pyrmont pyrmont marked this pull request as draft June 29, 2020 07:29
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 29, 2020
@pyrmont pyrmont self-assigned this Jun 29, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jul 4, 2020

@sogaiu I've streamlined the symbol and keyword patterns, simplified the number rules and added quoting support. How does it look to you?

@sogaiu
Copy link
Contributor Author

sogaiu commented Jul 4, 2020

Looks very nice! Thanks for all of the improvements and corrections 👍

@pyrmont pyrmont marked this pull request as ready for review July 5, 2020 02:36
@pyrmont pyrmont merged commit e870b5e into rouge-ruby:master Jul 5, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jul 5, 2020

@sogaiu Thanks for this 🎉 We release new versions of Rouge on a monthly cadence. The next version will be v3.21.0 and is scheduled for Tuesday 14 July. Depending on how you're using it (e.g. GitHub Pages, GitLab), it can take a bit of time before those projects start using the latest gem.

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
This commit adds a lexer for Janet.

Co-authored-by: Michael Camilleri <mike@inqk.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review The PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants