Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using grave character to escape characters in PowerShell lexer #1551

Merged
merged 4 commits into from
Jul 4, 2020
Merged

Support using grave character to escape characters in PowerShell lexer #1551

merged 4 commits into from
Jul 4, 2020

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jun 19, 2020

The ` character escapes characters in PowerShell statements. This PR adds support for it to the :paramaters state. It fixes #1542.

@pyrmont pyrmont self-assigned this Jun 19, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 19, 2020
@pyrmont
Copy link
Contributor Author

pyrmont commented Jun 19, 2020

@pekspro How's this look to you?

@pekspro
Copy link

pekspro commented Jun 20, 2020 •
edited
Loading

Due lack of skills, I am not able to compile and test this myself. But I have looked on the changes, and at least I can not say it something wrong 😁

I just want to mention that I just created issue #1557. It is very similar to this issue.

@pyrmont pyrmont merged commit c96bb98 into rouge-ruby:master Jul 4, 2020
@pyrmont pyrmont deleted the bugfix.powershell-grave-escape branch July 4, 2020 05:17
@pyrmont
Copy link
Contributor Author

pyrmont commented Jul 4, 2020

@pekspro Thanks! 🎉 This will be part of v3.21.0 of Rouge. That will be released on Tuesday 14 July.

I'll have a look at submitting a fresh PR to fix the other issue.

@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jul 4, 2020
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
@pyrmont @mattt
Support using grave character to escape characters in PowerShell lexer (
a1b0734 
rouge-ruby#1551)

The ` character escapes characters in PowerShell statements. This
commit adds support for it to the `:parameters` state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PowerShell and grave-accent
2 participants
@pyrmont @pekspro