Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow @ before REM in Batchfile lexer #1545

Merged

Conversation

KamilaBorowska
Copy link
Contributor

@ symbol tells the command interpreter to not show any prompts. Special casing it for rem so that using @ also indicates a comment.

This syntax is used by Gradle for instance: https://github.com/gradle/gradle/blob/master/gradlew.bat

@ symbol tells the command interpreter to not show any prompts.
Special casing it for `rem` so that using `@` also indicates a
comment.
@pyrmont pyrmont self-assigned this Jun 19, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 19, 2020
@pyrmont pyrmont merged commit f4aaa8a into rouge-ruby:master Jun 19, 2020
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 19, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jun 19, 2020

@xfix Thanks for this! It will be part of the next release of Rouge. Version 3.21.0 is scheduled to be pushed to RubyGems on Tuesday 14 July.

mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
The `@` symbol tells the command interpreter not to show any prompts.
This commit special cases it for `rem` so that using `@` also indicates
a comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants