Fix erroneous brace matching rule in JavaScript lexer #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
The JavaScript lexer contains a bug in the `:statement` state. This state contains a rule for lexing braces but this rule prevents Rouge from ever leaving the `:object` state. While this does not manifest itself in visible errors in most situations, it has the potential to cause subtle bugs and does not fit the mental model a user would have trying to understand how the JavaScript lexer is implemented. This commit fixes the problem by removing the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript lexer contains a bug in the
:statementstate. This state contains a rule for lexing braces but this rule prevents Rouge from ever leaving the:objectstate.While this does not manifest itself in visible errors in most situations, it has the potential to cause subtle bugs and does not fit the mental model a user would have trying to understand how the
JavaScript lexer is implemented.
This PR fixes the problem by removing the rule.