Add *.cshtml file glob to HTML lexer #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Cerbrus Does this look OK? |
Hi, thanks for taking a look at this. I'm not sure how I can check, though? |
|
@Cerbrus It is a little difficult. You could check out the code in the PR, update the HTML visual sample with some CSHTML and see how it looks but given that it's basically HTML with |
|
@Cerbrus OK—got it in. This will be part of the next version of Rouge: v3.20.0. That will be pushed out to RubyGems on Tuesday 9 June. Sorry for the wait! |
mattt
pushed a commit
to NSHipster/rouge
that referenced
this pull request
May 19, 2021
�����This commit adds the `*.cshtml` file glob to the HTML lexer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Razor syntax' is a feature of ASP.NET web programming. By convention, files that use this syntax, use the
.cshtmlextension. While Rouge does not properly support Razor syntax, discussion in #873 indicates that the HTML lexer would be preferable to these files being lexed as plaintext.This PR adds the file glob and a test. It fixes #873.