-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing keywords to LLVM lexer #1505
Add missing keywords to LLVM lexer #1505
Conversation
@guiferviz Thanks for the bug report. I had a look through the page you linked and I couldn't find the following keywords that you extracted from the Pygments lexer. Are these mistakes?
|
@pyrmont Thanks for your work. Unfortunately I'm not an LLVM expert and I can't tell you 100% sure what all those keywords are for. I've found this code that generates LLVM IR code (the code we are trying to highlight). Also, if you search for those words in the LLVM repository maybe you get a *.ll file with those keywords. *.ll is the extension of LLVM IR code. For example, in this link you will see all the files with We can:
|
Maybe I write to you so fast... I've just found this lexer. It's the official LLVM lexer for reading *.ll files! |
@guiferviz Thanks for finding that lexer file. I wrote a Rake task that will automatically generate the keywords and put them into a file that can then be loaded as needed. How does it look? |
It looks terrific! Now we are sure that it contains all the keywords. |
@guiferviz Thanks for your help on this! This will be part of the next version of Rouge: v3.19.0. That's scheduled for release on Tuesday 12 May. Thanks again! |
@pyrmont Thanks for your time! |
The list of keywords that is recognised in the current LLVM lexer is not as complete as in some other syntax highlighting libraries (such as Pygments). This commit adds a Rake task that checks a source file in the public LLVM repo and generates a keyword file that is loaded on request when the LLVM lexer is used.
There are a number of keywords missing from the LLVM lexer. This PR adds them to the appropriate group.
It fixes #1502.