Tokenise error messages in Console lexer #1498
Conversation
Add an "error" list option to the console lexer. Option default to nil. If non-nil, any line not already identified as a snip, prompt or comment - that starts with one of the strings in the option - will be tagged as `Generic::Error`
|
@gavlock Thanks for submitting this. It looks good! I should probably have done this through a separate PR but I took the opportunity to put the methods in this class into alphabetical order. That's not necessary by any means but in considering the placement of the |
pyrmont
changed the title
|
@gavlock OK, got it merged in :) This will go out as part of v3.18.0 of Rouge. That's scheduled for release on Tuesday 14 April (which, depending on when you're reading this, will either be today or tomorrow). Thanks again for the submission! 🎉 |
|
Thanks @pyrmont - looking forward to it :) |
The Console lexer is intended for use in lexing text that would be expected in a console. As a convenience, it allows an end-user to specify prompts and comment-demarcating characters. As a similar convenience, this commit adds an `error` list option. By default the value is `nil` but if specified by the end-user, any line (not already identified as a snip, prompt or comment) which begins with one of the strings in the option will be tokenised as `Generic::Error`. To assist in future review and maintenance, this commit also reorganises the methods in the class into alphabetical order.
Add an "error" list option to the console lexer.
Option default to nil.
If non-nil, any line not already identified as a snip, prompt or
comment - that starts with one of the strings in the option - will be
tagged as
Generic::ErrorThis closes #1487.