-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #264 add line highlighting option #1426
resolves #264 add line highlighting option #1426
Conversation
mojavelinux
commented
Feb 5, 2020
- add line highlighting option to HTMLLinewise formatter
- add dedicated formatter to add line highlighting (only marks highlighted lines)
Sorry about the delay, @mojavelinux. I got a bit side-tracked with various things. @jneen has expressed in the past a reluctance to add further formatters to Rouge. @jneen, what do you think about this PR? |
Thanks. As I said in #264, "If you think the additional formatter is unnecessary, I can remove it." |
This seems okay to me, mostly because it's its own class. My major reluctance is to adding options to existing formatters. |
- add line highlighting option to HTMLLinewise formatter - add dedicated formatter to add line highlighting (only marks highlighted lines)
0c153de
to
8275950
Compare
Thanks for reviewing. I've gone ahead and removed the change that introduced the additional options to the existing formatter. Let me know if you need me to make any other changes. |
Any updates on this / is there anything blocking? |
Looks good to me. It's using a |
and merged! thanks all <3 |
- add line highlighting option to HTMLLinewise formatter - add dedicated formatter to add line highlighting (only marks highlighted lines)