Remove sprintf format parsing for Rust lexer #1400
Conversation
Rust doesn't use sprintf parsing for its string formatting, using
Python-style formatting instead.
For instance, `print!("test %?", a.b)` would be written as
`print!("test {:?}", a.b)` in Rust today. The old syntax was
removed before 1.0, as such there is no real reason to support
it.
|
I need to have a think but I'm a little hesitant. One of the primary uses of Rouge is as a syntax highlighter for Jekyll-based blogs. It'd suck if you had some pre-1.0 code samples on your blog and they were highlighting fine and then suddenly they started having errors. |
|
In this case, That said, I suppose the Rust lexer also supports some pre-1.0 keywords, which are much bigger of a deal ( In fact, Just to be clear, I'm aware that I suppose not merging this is fine, but at the same time, merging this shouldn't affect the old code samples particularly much (sure, you lose highlighting on |
|
@xfix Thanks for the explanation. I agree with you that the fact it'll just be highlighted as part of the regular string limits the adverse impact. As for the other points, I think those are worthwhile fixes to consider but in a different issue/PR. I'll accept this and merge it in. |
Rust doesn't use sprintf parsing for its string formatting, using Python-style formatting instead.
For instance,
print!("test %?", a.b)would be written asprint!("test {:?}", a.b)in Rust today. The old syntax was removed before 1.0, as such there is no real reason to support it.