Well done @dehilsterlexis ! Can't wait for this to be merged and reflected in GitLab.

I have made corrections, updates and additions to the files. One thing I did not solve was the EMBED but will do that in a later push. I believe I have addressed all the comments.

@GordonSmith for review.

Changes made ready for review

@pyrmont for review

@pyrmont for review.

@pyrmont @GordonSmith I have pushed a new version addressing all the issues and added embedding.

When I was adding embedding I found what I think to be a possible problem with the lexer. I was looking to colorize the embedding keywords and the stuff in between as a string color and encountered a case where the lexer added a word to the text. Here is how you can recreate it. The part that is commented out is what I would want to really use instead of the line above:

        rule %r(\b(?i:(beginc\+\+.*?endc\+\+)))m, Str::Single
        rule %r(\b(?i:(embed.*?endembed)))m, Str::Single
        #rule %r(\b(?i:((embed)(.)*?(endembed))))m do
          #groups Keyword, Name::Other, Keyword
        #end

The output is here. You can see it added the first token m[0] at the end of the matched phrase and colorized is as if it was the first token. It literally inserts new text. Perhaps I am doing something wrong?

@pyrmont nudge

@dehilsterlexis I've pushed some changes to the PR. Hopefully the commit messages are self-explanatory but the key change is to avoid regex interpolation as much as possible by using more generic regular expressions. Hopefully it all makes sense.

When I was adding embedding I found what I think to be a possible problem with the lexer. I was looking to colorize the embedding keywords and the stuff in between as a string color and encountered a case where the lexer added a word to the text.

I think this was because you had a nested pattern. I've fixed this in the most recent commit. If you want to use a different lexer for the embedded text, RegexLexer#delegate is the method you want. You can see some examples of how it's used in other lexers here.

@ddehilster I'm ready to merge this. Is there anything left on your side?

@pyrmont we are good to go from our end

@dehilsterlexis Merge successful! We're on a monthly release cadence and the next version is scheduled to ship on Tuesday 10 March. This will be part of that release. Thanks for the contribution!

@pyrmont , is the ECL lexer live yet? we still don't see it reflected in our GitLab ecl code.

@dabittan The ECL lexer is part of Rouge v3.17.0 (dingus). I'm not associated with GitLab and don't know what version of Rouge they are running.