-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BibTeX Lexer #1360
Added BibTeX Lexer #1360
Conversation
Hello, I have rewritten the lexer and added the missing demo file. |
@alexlihengwang Thanks :) Will try to get to this over the weekend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR submission and sorry it's taken a bit of time to get to reviewing! I hope the comments all make sense but please feel free to ask if something is a bit inexplicable :)
@alexlihengwang Have you had a chance to look at the comments I made in December? |
Also pinging @ph03 given you filed the original issue. Perhaps you can answer some of the questions above. |
Having BibTeX support in rouge would allow for syntax highlighting in GitLab, which led me to this PR. I know nothing of Ruby, little about bib(la)tex but a thing or two about LaTeX in general. Therefore, I won't be able to help with code, but maybe still give you some useful pointers. The following is based on
Regarding your comments for the PR, @pyrmont , two things are shown there: numbers are indeed only As a side-note, it also says:
Ouch... anyway. Escaping quotes with
|
I think this is good to merge. I'll leave it for a couple more days in case there is any additional feedback. Thanks a lot for providing the information you did, @alexpovel. That was very helpful! |
Oh that was a pleasant resolve then, thanks @pyrmont ! Glad I could clear things up, after @alexlihengwang implemented everything. |
@alexlihengwang @alexpovel Thanks to both of you for your help on this. This will be part of the next version of Rouge, v3.20.0. That will be pushed to RubyGems on Tuesday 9 June 🎉 Thanks again! |
Thanks for the help @alexpovel @pyrmont |
This commit adds a lexer for BibTeX. Co-authored-by: Alex Liheng Wang <alw1@GS17003.SP.CS.CMU.EDU> Co-authored-by: Michael Camilleri <mike@inqk.net>
BibTeX Lexer based on PrismJS-BibTeX.
This fixes #1357.