Change method of saving MatLab built-in keywords #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid instantiating a large number of strings, Rouge currently saves the list of built-in keywords for MatLab to a file that is only read when the MatLab lexer is in use. The keywords that are in this file are generated by a Rake task that extracts the keywords from the official MatLab documentation.
Since the time that the Rake task was created, MathWorks (the creators of MatLab) have changed the way this page works such that it requires JavaScript to load. This breaks the Rake task.
As an alternative, this PR includes the list of built-in keywords in a YAML file. This is consistent with some of the other lexers that have a large number of keywords (e.g. Apache lexer).