Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lexer for CMHG files #1282

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Add a lexer for CMHG files #1282

merged 6 commits into from
Jul 31, 2019

Conversation

bavison
Copy link
Contributor

@bavison bavison commented Jul 26, 2019

This file format is parsed by the cmhg or cmunge tools to generate the
binary object header for privileged code modules on RISC OS - the initialism
stands for 'C Module Header Generator'.

This file format is parsed by the `cmhg` or `cmunge` tools to generate the
binary object header for privileged code modules on RISC OS - the initialism
stands for 'C Module Header Generator'.
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 26, 2019
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bavison I'm slowly working my way through all these submissions :) Here's some more comments!

lib/rouge/lexers/cmhg.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/cmhg.rb Show resolved Hide resolved
lib/rouge/lexers/cmhg.rb Show resolved Hide resolved
lib/rouge/lexers/cmhg.rb Outdated Show resolved Hide resolved
spec/visual/samples/cmhg Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jul 28, 2019
bavison added 4 commits July 30, 2019 15:02
Without this, testing for C preprocessor statements can't identify the leading
`#` character as being the first non-whitespace character on a line if it is
preceded by whitespace.
These two C preprocessor statements have no parameters, so do not require
following spaces.

Update visual sample to include an example of this (and of whitespace before
a `#` character).
@pyrmont pyrmont merged commit 7836be9 into rouge-ruby:master Jul 31, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jul 31, 2019

Another one down. Thanks @bavison! :)

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jul 31, 2019
bavison added a commit to bavison/rouge that referenced this pull request Sep 9, 2019
This commit adds a lexer for C Module Header Generator files. This file format is parsed by the `cmhg` or `cmunge` tools to generate the binary object header for privileged code modules on RISC OS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants