Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to self-hosted documentation #1270

Merged
merged 4 commits into from
Jul 24, 2019

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jul 22, 2019

Rouge's official documentation is hosted on RubyDoc.info. Recently, that site has frequently responded with 500 errors. This is problematic for various reasons, not least of which is it makes it difficult to refer potential contributors to the documentation for help in creating new lexers.

This PR provides the facility to integrate self-hosted documentation into Rouge's development process. The documentation is hosted on GitHub at present but this could be changed at a later point if desired.

It should be noted that the documentation generated still needs to be pushed to the docs repo manually.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jul 22, 2019
@ashmaroli
Copy link
Contributor

How about renaming the namespace to docs and having the task as generate?
Also, you could then add docs:publish task to commit the generated docs and push to the rouge-ruby/docs repo automatically.

@pyrmont pyrmont mentioned this pull request Jul 23, 2019
@pyrmont
Copy link
Contributor Author

pyrmont commented Jul 23, 2019

@ashmaroli I'm not sure if there's a consensus more broadly amongst the Ruby community but I looked at the tasks that were added by Bundler and the pattern seemed to be <verb>[:<noun>]. Indeed, that's what I followed as part of #1267 and, for the moment at least, I think it would be best to keep to that.

I added in the bit about not being able to automatically publish the documentation but I'm not too worried about that at this stage. It was more a note in case the expectation was that the documentation would magically get updated.

@pyrmont pyrmont force-pushed the feature.self-hosted-docs branch from cc834c1 to d0011a4 Compare July 24, 2019 00:03
@pyrmont pyrmont merged commit 7ff2d09 into rouge-ruby:master Jul 24, 2019
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jul 24, 2019
@pyrmont pyrmont deleted the feature.self-hosted-docs branch January 8, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants