-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added HOCON lexer. #1253
Added HOCON lexer. #1253
Conversation
The variables
|
I've removed the variables. |
@davidtwco Thanks for submitting this again and I'm sorry you've had to wait so long :( I'm looking at the informal spec and, given HOCON is a superset of JSON, it looks like this lexer would be best implemented as a subclass of In addition to simply redefining a rule that you need to operate differently, Rouge comes with the methods |
@pyrmont I've implemented this as a subclass of JSON, I think I've eliminated all the redundant rules and those that remain are necessary. |
Wow, that's fast! I'll have a look over it and let you know if I spot anything :) |
Pushed again to (hopefully) fix Travis failures and fix a missing word in a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a few questions:
This is a resubmission of #836.