Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #947: Add documentation on using Docker for development #1214

Merged
merged 2 commits into from
Jun 29, 2019

Conversation

nguillaumin
Copy link
Contributor

No description provided.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 25, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 25, 2019

@nguillaumin Thank you for contributing this. I have a couple of tweaks I want to make (partly in other docs that should cross reference this) so I'm sorry that's taking a while.

I did have a question generally, though. While I think having instructions to install through Docker is a good idea and I definitely want to include this, I was curious what you were referring to as 'dependencies'.

Maybe this is just my personal experience, but I've found Docker itself to generate many more dependencies to install and manage than Ruby. I understand you could mean the gem dependencies but these can be managed by having Bundler install into a directory within the project (which is in fact what you do with your Docker tasks).

The obvious counterargument was production systems. But is that what you had in mind?

@pyrmont
Copy link
Contributor

pyrmont commented Jun 26, 2019

@nguillaumin I hope this isn't too forward but I've pushed some changes directly to your branch. I've expanded and revised the wording, added cross references and inserted newlines into the text so that it wraps at 80 characters.

Please let me know what you think!

@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jun 26, 2019
@nguillaumin
Copy link
Contributor Author

Sorry didn't have time to reply earlier.

What I meant by dependencies is Ruby and everything that comes with it. I don't use Ruby generally so I don't necessarily want to install it on my system and everything that goes with it. For example I don't even know exactly what Bundler is 😉

I think you captured that we'll with your changes, so I'm fine with them. Thanks!

@pyrmont pyrmont merged commit 6b00713 into rouge-ruby:master Jun 29, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jun 29, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 29, 2019

Thanks for the submission, @nguillaumin! It should start appearing on RubyDocs after their next scheduled rebuild :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants