Fix untyped methods in Objective-C lexer #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Objective-C lexer prepends a rule to the `:root` state that is intended to match a method definition. Although the regular expression indicates that the return type of the method may not match anything, it was nevertheless passing the result to `RegexLexer#recurse` regardless of whether it was nil or not. If this occurred with an untyped instance method, the output would insert an additional `-` in the output. Checking whether to call `RegexLexer#recurse` on the basis of whether the value was non-nil fixed the problem. This fixes rouge-ruby#1076.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Objective-C lexer prepends a rule to the
:rootstate that is intended to match a method definition. Although the regular expression indicates that the return type of the method may not match anything, it was nevertheless passing the result toRegexLexer#recurseregardless of whether it was nil or not.If this occurred with an untyped instance method, the output would insert an additional
-in the output. Checking whether to callRegexLexer#recurseon the basis of whether the value was non-nil fixed the problem. This fixes #1076.