@malukenho Sorry, excuse my last message. I'll submit a review on your code now with some points to look at. It'll come through in a bit.

Having now had the benefit of an extra three months as a Rouge maintainer, there were further changes to this lexer that I would recommend making beyond those identified in the 2 June review. Given how long it's been since the original submission, it felt like it made more sense to make those changes myself.

@malukenho I hope you don't mind me taking the liberty of force pushing the changes to your fork. I also hope all the changes make sense but please let me know if you have any comments. I realise now that this was very closely based on the Java lexer. I think my changes shouldn't cause issues but if you notice anything broken, let me know!

I will note that my version is slightly less flexible when lexing function definitions. I believe this should only be an issue for definitions that use spaces between the function name and the opening parenthesis (which I don't think is very common) and so don't expect this to be a problem in practice.