Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warning in Lexer #1087

Merged
merged 1 commit into from
May 27, 2019
Merged

fix warning in Lexer #1087

merged 1 commit into from
May 27, 2019

Conversation

mojavelinux
Copy link
Contributor

  • don't reference undefined instance variable

@mojavelinux
Copy link
Contributor Author

I'm happy to take a different strategy. Please advise.

@pyrmont
Copy link
Contributor

pyrmont commented May 13, 2019

What warning are you referring to here?

@mojavelinux
Copy link
Contributor Author

Accessing an undefined instance variable, @debug_enabled.

@mojavelinux
Copy link
Contributor Author

(You see this when adding the -w flag when invoking Ruby).

@pyrmont pyrmont mentioned this pull request May 13, 2019
Merged
@mojavelinux
Copy link
Contributor Author

Btw, the reason all the builds are failing is because the version of bundler is hardcoded in the Gemfile. This dependencies has no place in the Gemfile and should be removed. I'll submit a separate PR to address it.

@pyrmont
Copy link
Contributor

pyrmont commented May 27, 2019

@mojavelinux Can you push an empty commit? That'll trigger a new build by Travis.

@mojavelinux
fix warning in Lexer
c4491f2 
- don't reference undefined instance variable
@mojavelinux
Copy link
Contributor Author

Done.

@pyrmont pyrmont merged commit b1e81b8 into rouge-ruby:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mojavelinux @pyrmont