Fix #1022 by supporting diffs other than unified. #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close rouge-ruby#846 as it conflicts and this commit differentiates further.
|
For what it's worth, looks good to me! |
pyrmont
added
the
author-action
|
The "@@" references are already covered by the current diff. Example of non-unified diff incoming. |
pyrmont
added
needs-review
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #846 as it conflicts and this commit differentiates further.
In addition to handling diffs done without the "-u" flag, this also more closely matches "git diff" output for unified diffs by treating
@@ [reference ] @@as punctuation and the rest of the line as text, making "---" punctuation, and making the diff/index lines at the top headings.