Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CSV Schema language #1039

Merged
merged 13 commits into from
Sep 17, 2019
Merged

Added CSV Schema language #1039

merged 13 commits into from
Sep 17, 2019

Conversation

filipegarcia
Copy link
Contributor

About CSV Schema:

A text based schema language (CSV Schema) for describing data in CSV files for the purposes of validation. Released as Open Source under the Mozilla Public Licence version 2.0.

More info at http://digital-preservation.github.io/

@vidarh vidarh mentioned this pull request Jan 13, 2019
Closed
@pyrmont pyrmont mentioned this pull request May 12, 2019
Merged
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label May 28, 2019
pyrmont
pyrmont suggested changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipegarcia Sorry it's taken so long to get this reviewed! Please let me know if you have any questions :)

lib/rouge/lexers/csvs.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/csvs.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/csvs.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/csvs.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/csvs.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/csvs.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/csvs.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed and removed needs-review The PR needs to be reviewed labels Jun 13, 2019
@pyrmont pyrmont self-assigned this Aug 26, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Sep 4, 2019

@filipegarcia It's been a couple of months since my earlier review and I've had a bit more time to become better acquainted with Rouge so I took a look at making some of the changes I suggested above. In the course of doing so, I realised that there was quite a gap between the lexer as originally written and the spec.

I hope you don't mind but I've force pushed an updated version of the lexer and the visual testing file that, to me at least, better conforms with the CSVS spec. I'm not sure if you're still following this PR but I'll look to merge this before the next release of Rouge (scheduled for 17 September).

Please let me know if you have any comments!

@pyrmont pyrmont merged commit 46ce2ac into rouge-ruby:master Sep 17, 2019
@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont approved these changes

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipegarcia @pyrmont