Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add application/problem+json and application/schema+json to json known mimetypes. #1030

Merged
merged 2 commits into from
Jun 19, 2019
Merged

Add application/problem+json and application/schema+json to json known mimetypes. #1030

merged 2 commits into from
Jun 19, 2019

Conversation

duncangodwin
Copy link
Contributor

No description provided.

@duncangodwin
Update json.rb
0d3f187 
Add application/problem+json and application/schema+json to json known mimetypes.
@pyrmont pyrmont mentioned this pull request May 14, 2019
Closed
@pyrmont
Copy link
Contributor

pyrmont commented May 28, 2019

@duncangodwin It's been a while but we're finally making some progress clearing up old issues :) Would you be able to update the JavaScript spec to test for these filetypes?

rouge/spec/lexers/javascript_spec.rb

Lines 24 to 29 in 95134f8

it 'guesses by mimetype' do
assert_guess :mimetype => 'text/javascript'
assert_guess Rouge::Lexers::JSON, :mimetype => 'application/json'
assert_guess Rouge::Lexers::JSON, :mimetype => 'application/vnd.api+json'
assert_guess Rouge::Lexers::JSON, :mimetype => 'application/hal+json'
end

@pyrmont pyrmont added the author-action The PR has been reviewed but action by the author is needed label May 28, 2019
@pyrmont pyrmont merged commit 9b6a686 into rouge-ruby:master Jun 19, 2019
@pyrmont
Copy link
Contributor

pyrmont commented Jun 19, 2019

@duncangodwin Sorry to take the liberty of pushing to your branch but didn't think you'd mind. Thanks for the contribution!

@pyrmont pyrmont removed the author-action The PR has been reviewed but action by the author is needed label Jun 19, 2019
@glensc
Copy link

glensc commented Jun 19, 2019

related rfc: https://tools.ietf.org/html/rfc7807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncangodwin @pyrmont @glensc