Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded CSS for tables #1217

Closed
pyrmont opened this issue Jun 25, 2019 · 2 comments
Closed

Remove hard-coded CSS for tables #1217

pyrmont opened this issue Jun 25, 2019 · 2 comments
Labels
enhancement-request A request for an enhancement to be developed. stale-issue There has been no activity for a year.

Comments

@pyrmont
Copy link
Contributor

pyrmont commented Jun 25, 2019

Is your enhancement request related to a problem? Please describe.
Rouge 3.0 hard codes CSS for certain table elements into the theming output. Specifically:

rouge/lib/rouge/theme.rb

Lines 164 to 174 in ab36916

def render(&b)
return enum_for(:render).to_a.join("\n") unless b
# shared styles for tableized line numbers
yield "#{@scope} table td { padding: 5px; }"
yield "#{@scope} table pre { margin: 0; }"
styles.each do |tok, style|
Style.new(self, style).render(css_selector(tok), &b)
end
end

Describe the solution you'd like
Rouge should not output these CSS rules. It should be left for the stylesheet.

Additional context
This was discussed briefly here.
@pyrmont pyrmont added the enhancement-request A request for an enhancement to be developed. label Jun 25, 2019
@jneen
Copy link
Member

jneen commented Jul 2, 2019

This will need to be on a major version release, as it will definitely break styling on people's websites.

@ashmaroli ashmaroli mentioned this issue Jul 24, 2019
Closed
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically marked as stale because it has not had any activity for more than a year. It will be closed if no additional activity occurs within the next 14 days.
If you would like this issue to remain open, please reply and let us know if the issue is still reproducible.

@stale stale bot added the stale-issue There has been no activity for a year. label Jul 2, 2020
@stale stale bot closed this as completed Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement-request A request for an enhancement to be developed. stale-issue There has been no activity for a year.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pyrmont @jneen