Add Ubuntu 24.04 Noble and switch Rolling to it #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophebedard
requested review from
emersonknapp and
MichaelOrlov
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #842 +/- ##
=======================================
Coverage 45.81% 45.81%
=======================================
Files 2 2
Lines 299 299
Branches 80 80
=======================================
Hits 137 137
Misses 162 162 ☔ View full report in Codecov by Sentry. |
MichaelOrlov
approved these changes
Mar 18, 2024
Comment on lines
+255
to
+262
| - os: macOS-latest | ||
| ros_distribution: humble | ||
| - os: macOS-latest | ||
| ros_distribution: iron | ||
| - os: macOS-latest | ||
| ros_distribution: rolling |
There was a problem hiding this comment.
@christophebedard AFAIK we don't support macOS officially anymore.
Can we remove these macOS related items?
There was a problem hiding this comment.
ROS 2 officially doesn't support macOS anymore as tier 1 or 2, but setup-ros/action-ros-ci don't officially not support it. It's just been kind of broken for a while. I would leave it there for now and consider removing it separately.
Closed
christophebedard
force-pushed
the
christophebedard/ubuntu-noble-rolling
branch
4 times, most recently
from
a4d07ab to
a4d14c8
Compare
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
christophebedard
force-pushed
the
christophebedard/ubuntu-noble-rolling
branch
from
a4d14c8 to
dbb5ee7
Compare
|
Since this works and pretty much only affects the local tests, I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ros-tooling/setup-ros#658
See also ros-tooling/setup-ros-docker#69
Note: the ubuntu-24.04 GitHub runner is not available yet: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#choosing-github-hosted-runners. I changed the workflow configs to use a Ubuntu Noble Docker image on top of ubuntu-latest. We could just keep this and not have to remove the workaround + bring it back for Ubuntu 26.04.
The
Test rosdep check/skip install optionsCI job is failing, but I suspect that it is related to ros-tooling/setup-ros-docker#67 and not these changes.