Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix boundary point exclusion in convexFillCells #1095

Merged
merged 1 commit into from
Mar 3, 2021
Merged

fix boundary point exclusion in convexFillCells #1095

merged 1 commit into from
Mar 3, 2021

Conversation

ChristofDubs
Copy link
Contributor

A bug in the function that returns all the cells contained in a (convex) polygon:

  • sorts all the points along the polygon outline by x coordinate
  • for all points with same x coordinate, find min and max y coordinate
  • for that x coordinate, considers all points between min and max y coordinate to be within the polygon

The bug is that the maximum y coordinate also needs to be included.

@ChristofDubs ChristofDubs mentioned this pull request Jan 31, 2021
Merged
@mikeferguson mikeferguson merged commit 996ccec into ros-planning:noetic-devel Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeferguson mikeferguson mikeferguson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristofDubs @mikeferguson