Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

costmap_2d: unused and buggy testing helper functions #1069

Closed
jdalbosc opened this issue Dec 17, 2020 · 0 comments
Closed

costmap_2d: unused and buggy testing helper functions #1069

jdalbosc opened this issue Dec 17, 2020 · 0 comments

Comments

@jdalbosc
Copy link
Contributor

Hello

I was going over the costmap_2d code and I came across the setValues function in costmap_2d/include/costmap_2d/testing_helper.h which:
1/ seems to be buggy as the local index counter inside it is never incremented whereas it looks as it shoud be,
2/ is not used anywhere else in the code.

I propose to remove this function which seems to be useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant