Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make operator bool() explicit #696

Merged
merged 1 commit into from
Dec 1, 2017
Merged

Make operator bool() explicit #696

merged 1 commit into from
Dec 1, 2017

Conversation

simonschmeisser
Copy link
Contributor

this is not as likely to cause bugs as the respective change in #670
as there is an implicit operator Value() [1] that gets used for comparison

still I think this should be explicit

[1] Value being the name of the enum

@simonschmeisser
Make operator bool() explicit
290ecfa 
this is not as likely to cause bugs as the respective change in #670
as there is an implicit operator Value() that gets used for comparison

still I think this should be explicit
mlautman
mlautman approved these changes Dec 1, 2017
View reviewed changes
Copy link
Contributor

@mlautman mlautman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davetcoleman davetcoleman merged commit 8708a38 into moveit:kinetic-devel Dec 1, 2017
@simonschmeisser simonschmeisser deleted the explicit_operator_bool_ExecutionStatus branch December 3, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlautman mlautman mlautman approved these changes

@davetcoleman davetcoleman davetcoleman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonschmeisser @davetcoleman @mlautman