Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Point2d message, and use it in Pose2D #67

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Add Point2d message, and use it in Pose2D #67

merged 2 commits into from
Mar 17, 2022

Conversation

ijnek
Copy link
Member

@ijnek ijnek commented Mar 16, 2022

Resolves: #66

@ijnek
add Point2D message
9e91a6e 
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek ijnek changed the base branch from noetic-devel to ros2 March 16, 2022 06:10
@ijnek ijnek mentioned this pull request Mar 16, 2022
Closed
SteveMacenski
SteveMacenski approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kukanani ?

Kukanani
Kukanani approved these changes Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@Kukanani Kukanani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; let's call out our units explicitly

msg/Point2D.msg Outdated Show resolved Hide resolved
@ijnek @Kukanani
Update msg/Point2D.msg
13005f3 
Co-authored-by: Adam Allevato <Kukanani@users.noreply.github.com>
@Kukanani Kukanani merged commit ec4fd46 into ros-perception:ros2 Mar 17, 2022
@Kukanani
Copy link
Collaborator

Thanks for the code :)

@ijnek ijnek deleted the ijnek-point-2d branch March 17, 2022 02:42
@ijnek
Copy link
Member Author

ijnek commented Mar 20, 2022

@Kukanani Would you be able to make a rolling release with the new changes when you've got the time?

@ijnek ijnek mentioned this pull request Mar 20, 2022
Closed
@Kukanani
Copy link
Collaborator

ros/rosdistro#32485

@ijnek
Copy link
Member Author

ijnek commented Mar 20, 2022

Thanks @Kukanani

@ijnek ijnek mentioned this pull request Mar 30, 2022
Closed
@2b-t 2b-t mentioned this pull request Jun 1, 2023
Merged
@sloretz sloretz mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

@Kukanani Kukanani Kukanani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion for new msg type: vision_msgs/Point
3 participants
@ijnek @Kukanani @SteveMacenski