V4l2 devices might not be named video #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flynneva
force-pushed
the
v4l2-devices-might-not-be-named-video
branch
from
4ba12c0 to
ee38ed8
Compare
|
fyi @firesurfer this should resolve #312 |
flynneva
commented
Jan 20, 2024
| @@ -146,31 +151,41 @@ inline std::map<std::string, v4l2_capability> available_devices() | |||
| // Initialize vector of device strings to fill in | |||
| std::map<std::string, v4l2_capability> v4l2_devices; | |||
|
|
|||
| // V4L2 spec says there can only be a maximum of 64 devices | |||
| const uint8_t MAX_DEVICES = 64; | |||
| // Get a list of all v4l2 devices from /sys/class/video4linux | |||
There was a problem hiding this comment.
@firesurfer the list in /sys/class/video4linux should include all valid v4l2 devices I think...even if they are /dev/media devices
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
flynneva
force-pushed
the
v4l2-devices-might-not-be-named-video
branch
from
ee38ed8 to
7ff4e65
Compare
|
Hi @flynneva sorry I didn't get to test this PR yet. We are currently migrating to a new hardware setup and it will take sometime until I have the cameras ready again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #312