263 check if specified pixel format is supported #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now if someone tries to specify a pixel format that this driver doesnt support, it'll error out and tell you:
Then if the specified pixel format is supported by the driver, but not supported by the selected device it'll error:
|
flynneva
force-pushed
the
263-check-if-specified-pixel-format-is-supported
branch
2 times, most recently
from
12332df to
d537c1d
Compare
- Use common arguments struct in all format classes Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
flynneva
force-pushed
the
263-check-if-specified-pixel-format-is-supported
branch
from
d537c1d to
8aadf43
Compare
- Also fix typo in params_2 yaml file - fix linter errors too Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
flynneva
force-pushed
the
263-check-if-specified-pixel-format-is-supported
branch
from
8aadf43 to
d9d12d4
Compare
|
@flynneva When I use the correct pixel format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pixel_format:=uyvy/ yuv422, even when not supported by the device, and sends images with the wrongencodingvalue #263Throws a verbose error for now instead of silently falling back to some random format. In the future we might be able to add some logic to auto-determine the "best" available pixel format and fall back to that
This also lets us clean up the
set_pixel_formatlogic to be much more maintainable and easier to understand.