Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add camera info #158

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Conversation

wep21
Copy link

@wep21 wep21 commented Jun 18, 2021

Add camera info publisher and sample camera info yaml.

wep21 added 2 commits June 19, 2021 07:31
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Author

wep21 commented Jun 18, 2021

@flynneva Could you also check this?

@flynneva
Copy link
Collaborator

@wep21 these PR's are great! Keep them coming 😃

LGTM

@flynneva flynneva merged commit b675c2e into ros-drivers:ros2 Jun 18, 2021
@wep21 wep21 deleted the feature/add_camera_info branch June 18, 2021 23:15
@flynneva
Copy link
Collaborator

flynneva commented Jun 18, 2021

@wep21 shoot I just realized you have test_cam and test_camera frame ids. did you want these to match? ill go ahead and edit them to both be test_camera

@wep21
Copy link
Author

wep21 commented Jun 18, 2021

@flynneva Oh, I'm sorry... I think it's better to have the same name. I appreciate if you colud match them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants