-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ros2] Lint/make utils file #153
Conversation
@Karsten1987 wanted to get your opinion here. I cant think of any drawbacks to moving |
5501ee8
to
45826e2
Compare
also a pretty major change in this one is the creation of the |
The way I'd consider this is that at this moment you don't have to deal with API/ABI or even style/behavior changes on the ROS2 branch as there aren't any binary releases for it yet, is that right? |
hi @Karsten1987, yes sorry about the i'll merge together all these updates into one commit so we can move forward |
28ec502
to
904a088
Compare
@Karsten1987 pinging you one more time to look this PR over before merging. let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
usb_cam.h
tousb_cam.hpp
(should we keepusb_cam.h
and just include the.hpp
version for awhile?)usb_cam.cpp
and intousb_cam_utils.hpp
to keep the code clean & separate