so i added in some ROS2 github actions to this PR since I would guess the travis CI is still probably setup for ROS1.

not sure why they arent running....maybe there is a setting on this repo to enable github actions from a forked repo?

great effort! Thanks for picking this up.

maybe there is a setting on this repo to enable github actions from a forked repo

There is an option to enable this but I believe it's generally not really recommended due to security risks:
https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/

@k-okada I would think it makes sense to merge this as a first version and come up with potential fixes to it later. Alternatively, you could push a copy of this branch upstream to validate the GH actions.

im almost done fixing the ament_cpplint errors, give me like 10 more minutes! 😄

here are the github actions running on my fork if you'd like to see them before merging

so there are still some ament_copyright errors but i figured I would leave those for the maintainers.

ive fixed the ament_cpplint errors and confirmed functionality again using a usb camera and foxy. you can see the successful ROS2 CI running on this pr on my forked repo as well.

ive tested it locally again after all these changes and i can confirm it functions as expected and outputs an image stream from a usb camera.

@Karsten1987 @k-okada @rctoris just added myself as a maintainer to my already-open PR.

Let me know what else is missing before getting this merged.

I'd personally prefer a dedicated PR for the hand-off. That way we don't have to wait for the actual PR to land in order for you to take over some of the responsibilities.
Also, that way you can easily declare which branches you want to maintain.

i think this is ready for at least a cursory review @Karsten1987 or @lucasw or @k-okada .

you can see the new CI running over on my forked repo.

once merged we should see then ROS2 Github Actions run on all branches beginning with ros2/*. in the future we could add specific branches for distros if needed and add them to the list.

definitely going to be some some more change soon though as i still think the ROS2 version of this is barely usable as-is.

ok going to go ahead and merge this into the ros2 branch. this should give us a good baseline to build from.

a bit late here, but there's quite some commented code. Are you planning/willing to clean this up and address the outstanding TODOs?

It's a bit unfortunate that you introduced the boost dependency. We've been trying quite hard to not have a dependency on it for a while now in the context of ROS2. Not a show-stopper at all, I was just wondering if there's an alternative to the lexical cast.

@Karsten1987 the reason why I merged this without "further improvements" is because the previous ros2 branch was still actually a ROS1 package. i just wanted a "base line" to build from.

removing boost dependencies will definitely take top priorty moving forward to bring up the driver.