Reorder waiting for services and ros time to speed up controller start #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this please? It should fix the problems in both use cases. |
bmagyar
approved these changes
Jan 31, 2023
|
Thank you for figuring this out. Can we do this for melodic as well? @bmagyar @Martin-Oehler |
ravikola02
added a commit
to ravikola02/ros_control
that referenced
this pull request
Feb 17, 2023
…t for melodic branch These changes are to resolve issue ros-controls#507 , which was updated for noetic in ros-controls#508 but not for melodic branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
this PR addresses issue #507. I reordered the code structure so
waiting_for_servicehappens first and only if that times out, check for running sim time happens.Maybe @guillaumeautran could also check, if this works for them?
Best regards,
Martin