Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(assets) nested directories #925

Merged
merged 1 commit into from
Jan 4, 2022
Merged

fix(assets) nested directories #925

merged 1 commit into from
Jan 4, 2022

Conversation

kellymears
Copy link
Contributor

Type of change

  • PATCH: bugfix

Dependencies added

  • none

Details

  • fixes filepath flattening of assets emitted by copy-webpack-plugin extension.
  • @retlehs I think @roots/sage currently has this set up without calling bud.path. We should call bud.path.
bud.assets(['resources/images'])

should be:

bud.assets([bud.path('src', 'images')])

It's possible in the future to sniff this out but for now it wants an absolute path. This is to better support copying from assets that aren't the source directory.

@kellymears kellymears requested review from retlehs and QWp6t January 4, 2022 19:29
@kellymears kellymears self-assigned this Jan 4, 2022
@kellymears kellymears merged commit 7ed5e89 into next Jan 4, 2022
@kellymears kellymears deleted the fix-nested-copying branch January 4, 2022 19:51
@kellymears kellymears mentioned this pull request Jan 4, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retlehs retlehs retlehs approved these changes

@QWp6t QWp6t Awaiting requested review from QWp6t

Assignees

@kellymears kellymears

Labels
examples @roots/bud-api test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellymears @retlehs