Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(patch): @roots/sage preset #1172

Merged
merged 6 commits into from
Feb 22, 2022
Merged

improve(patch): @roots/sage preset #1172

merged 6 commits into from
Feb 22, 2022

Conversation

kellymears
Copy link
Contributor

Overview

Two small changes to @roots/sage:

  • we can set the path in the extension now (remove from roots/sage package.json).
  • we don't need to set / as the public path in development with acorn fixes in place

refers: none
closes: none

Type of change

  • PATCH: Backwards compatible bug fix

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

@kellymears kellymears changed the title set paths in extension (remove from sage manifest) improve(patch): @roots/sage preset Feb 19, 2022
@github-actions github-actions bot added the test label Feb 20, 2022
@kellymears kellymears merged commit 73dde3a into main Feb 22, 2022
@kellymears kellymears deleted the improve-sage-extension branch February 22, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retlehs retlehs retlehs approved these changes

@QWp6t QWp6t Awaiting requested review from QWp6t

@swalkinshaw swalkinshaw Awaiting requested review from swalkinshaw

Assignees
No one assigned
Labels
examples @roots/sage test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellymears @retlehs