Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: eslint/stylelint base config #1134

Merged
merged 7 commits into from
Feb 13, 2022
Merged

improve: eslint/stylelint base config #1134

merged 7 commits into from
Feb 13, 2022

Conversation

kellymears
Copy link
Contributor

@kellymears kellymears commented Feb 10, 2022 •
edited
Loading

Overview

  • Improves stylelint presets for @roots/bud-preset-wordpress and @roots/sage.
  • Removes @roots/bud-eslint from @roots/bud-preset-wordpress
  • Removes @roots/bud-eslint from @roots/bud-preset-recommend
  • Adds @roots/bud-eslint to @roots/sage

refers: none
closes: none

Type of change

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • @roots/bud-preset-wordpress no longer includes @roots/bud-eslint
  • @roots/bud-preset-recommend no longer includes @roots/bud-eslint

users who wish to use eslint need to install @roots/bud-eslint.

Proposed changes

  • ⚠️ [@roots/bud-preset-recommend] breaking: remove @roots/bud-eslint
  • ⚠️ [@roots/bud-preset-wordpress] breaking: remove @roots/bud-eslint
  • [@roots/bud-preset-wordpress] add: @roots/bud-preset-wordpress/stylelint-config export
  • [@roots/bud-preset-wordpress] fix: stylelint config disables 'custom-property-pattern' (in conflict with --wp naming convention)
  • [@roots/sage] add: @roots/bud-eslint

@github-actions github-actions bot added @roots/bud-preset-wordpress @roots/sage dependencies Pull requests that update a dependency file labels Feb 10, 2022
@kellymears kellymears self-assigned this Feb 10, 2022
@github-actions github-actions bot added the test label Feb 11, 2022
@kellymears kellymears changed the title improve: stylelint base configs improve: eslint/stylelint base config Feb 11, 2022
@kellymears kellymears merged commit 97c0297 into main Feb 13, 2022
@kellymears kellymears deleted the improve-stylelint-preset branch February 13, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalkinshaw swalkinshaw swalkinshaw approved these changes

Assignees

@kellymears kellymears

Labels
dependencies Pull requests that update a dependency file @roots/bud-preset-recommend @roots/bud-preset-wordpress @roots/bud-stylelint @roots/sage test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellymears @swalkinshaw