GKE uses a non-standard FlexVolume directory which is not documented. #2126
Conversation
|
@ayaz Thanks for the fix! You need to add your sign-off to the commit, for more information see: https://github.com/rook/rook/blob/master/CONTRIBUTING.md#certificate-of-origin |
Documentation/flexvolume.md
Outdated
| @@ -11,6 +11,7 @@ This is the case for Kubernetes deployments on: | |||
| * [ContainerLinux](https://coreos.com/os/docs/latest/) (previously named CoreOS) | |||
| * [OpenShift](https://www.openshift.com/) | |||
| * [Rancher](http://rancher.com/) | |||
| * [GKE](https://cloud.google.com/kubernetes-engine/) | |||
There was a problem hiding this comment.
Would you mind writing it in full and having GKE in braces after the name Google Kubernetes Engine (GKE).
There was a problem hiding this comment.
Thanks @galexrt I've modified it and also signed-off.
There was a problem hiding this comment.
You have only changed it below, but here it also needs to be changed.
There was a problem hiding this comment.
Please go ahead and squash your commits into one commit.
Also could you make your commit message conform to the convention here: https://github.com/rook/rook/blob/master/CONTRIBUTING.md#commit-messages
Documentation/flexvolume.md
Outdated
| @@ -11,6 +11,7 @@ This is the case for Kubernetes deployments on: | |||
| * [ContainerLinux](https://coreos.com/os/docs/latest/) (previously named CoreOS) | |||
| * [OpenShift](https://www.openshift.com/) | |||
| * [Rancher](http://rancher.com/) | |||
| * [GKE](https://cloud.google.com/kubernetes-engine/) | |||
There was a problem hiding this comment.
You have only changed it below, but here it also needs to be changed.
Google Kubernetes Engine uses a non-standard FlexVolume directory which is not documented. This change updates the FlexVolume documentation to describe how to configure FlexVolume for use on Google Kubernetes Engine. Signed-off-by: Ayaz Ahmed Khan <ayaz@ayaz.pk>
|
@galexrt Sorry, my bad. I missed that. Could you please tell me which approach you use for squashing? I rebased the three commits into one, but when I push the resulting commit to upstream on my fork, it complains about the current branch being behind the remote (even though both were in sync before the rebase). |
|
@galexrt Actually, never mind that. I did a force push. Is everything all right now? |
|
@ayaz When you rebase (and/or squash during the rebase) you need to force push as the remote is behind due to your local branch being just one commit now and the remote branch is still one or more commits (with other commit IDs) than the one locally. |
Description of your changes:
FlexVolume on Rook doesn't work out of the box on Google's Kubernetes Engines (GKE). GKE uses a non-standard FlexVolume directory which isn't currently documented.
Which issue is resolved by this Pull Request:
It only updates documentation for FlexVolume.
Checklist:
make codegen) has been run to update object specifications, if necessary.make vendordoes not cause changes.[skip ci]