Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the 'cross' build on AArch64 #1674

Merged
merged 1 commit into from
May 15, 2018

Conversation

arm64b
Copy link
Member

@arm64b arm64b commented Apr 26, 2018

AArch64 platform doesn't support the build.all command due to the issue of hypriot/qemu-register on arm64 system, so we disable this kind of 'cross' build on AArch64 platform.

Signed-off-by: Dennis Chen dennis.chen@arm.com

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • [* ] Documentation has been updated, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.

AArch64 platform doesn't support the `build.all` command due to the
`hypriot/qemu-register` issue, so we disable this kind of 'cross' build
on AArch64 platform.

Signed-off-by: Dennis Chen <dennis.chen@arm.com>
@arm64b arm64b force-pushed the disable-cross-build-on-arm64 branch from aee5649 to 4679fe5 Compare April 26, 2018 08:17
@arm64b
Copy link
Member Author

arm64b commented Apr 26, 2018

Will check the missed ceph package on arm64 failure tomorrow...

@arm64b
Copy link
Member Author

arm64b commented May 2, 2018

Ah, sudden to find that the CI has become green 😄 Seems there's a broken period for the Rook CI...

@galexrt
Copy link
Member

galexrt commented May 10, 2018

@arm64b @bassam The CI is green now and Ceph has fixed the ARM package issue AFAIK (if I'm not wrong with what I heard).

Anything standing in the way of this PR getting merged?

@arm64b
Copy link
Member Author

arm64b commented May 10, 2018

@galexrt

Anything standing in the way of this PR getting merged?

Nope, so please go ahead.

@arm64b
Copy link
Member Author

arm64b commented May 15, 2018

@galexrt is there any concern to merge this PR now?

@bassam bassam merged commit f6abaec into rook:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants