object: add opsLogSidecar to gateway subsection from zone #15199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a commit body and description to the github PR that explains what is changing? |
BlaineEXE
reviewed
Dec 18, 2024
deploy/examples/object.yaml
Outdated
Comment on lines
115
to
117
| #zone: | ||
| #name: zone-a | ||
| # service endpoint healthcheck |
There was a problem hiding this comment.
Let's take some time to fix the formatting of the comment here as well to match the rest of the example, and to fix the broken indentation of name.
Suggested change
| #zone: | |
| #name: zone-a | |
| # service endpoint healthcheck | |
| # zone: | |
| # name: zone-a | |
| # service endpoint healthcheck |
ideepika
force-pushed
the
wip-rgw-sidecar
branch
from
5b39e5a to
7b6cafa
Compare
@ideepika LGTM, if you could also add the brief description, thanks |
Update YAML configuration to correctly place the opsLogSidecar field under gateway.opsLogSidecar instead of zone.opsLogSidecar, as it is a configuration option specific to the RGW gateway. Signed-off-by: Deepika Upadhyay <deepika.upadhyay@clyso.com>
ideepika
force-pushed
the
wip-rgw-sidecar
branch
from
7b6cafa to
e821edc
Compare
BlaineEXE
approved these changes
Dec 20, 2024
6 tasks
travisn
added a commit
that referenced
this pull request
Jan 2, 2025
object: add opsLogSidecar to gateway subsection from zone (backport #15199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct yaml config for opsLogSidecar field from zone.opsLogSidecar to gateway.opsLogSidecar
Checklist: