Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbdmirror: rbd import cmd stuck forever #15051

Merged
merged 1 commit into from
Nov 26, 2024
Merged

rbdmirror: rbd import cmd stuck forever #15051

merged 1 commit into from
Nov 26, 2024

Conversation

parth-gr
Copy link
Member

@parth-gr parth-gr commented Nov 25, 2024 •
edited
Loading

if the import from the peer cluster doesnt
work, because of some reasons like
cluster health, network, etc

the import cmd stuck forever and which
forever stucks the blockppol reconcile

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@parth-gr parth-gr requested a review from sp98 November 25, 2024 08:46
@sp98
Copy link
Contributor

sp98 commented Nov 25, 2024

currently the blockpool reconcile stop at
bootstrap secret,

Why does it stop?
It should either complete or show some error? Is there any error?

@parth-gr
rbdmirror: rbd import cmd stuck forever
996a88f 
if the import from the peer cluster doesnt
work, because of some reasons like
cluster health, network, etc

the import cmd stuck forever and which
forever stucks the blockppol reconcile

Signed-off-by: parth-gr <partharora1010@gmail.com>
@parth-gr parth-gr changed the title rbdmirror: fix rbd mirroring monitoring reconcile rbdmirror: rbd import cmd stuck forever Nov 25, 2024
@parth-gr
Copy link
Member Author

parth-gr commented Nov 25, 2024 •
edited
Loading

currently the blockpool reconcile stop at
bootstrap secret,

Why does it stop? It should either complete or show some error? Is there any error?

Actually, it seems stuck and the controller doesn't progress as discussed offline.

@travisn
Copy link
Member

travisn commented Nov 25, 2024

In this error scenario, the reconcile will still never complete, right? But at least the reconcile will fail and try again. So hopefully the health issue can be resolved since there is evidence of the failure.

@parth-gr
Copy link
Member Author

In this error scenario, the reconcile will still never complete, right? But at least the reconcile will fail and try again. So hopefully the health issue can be resolved since there is evidence of the failure.

yaa correct, it will actually showcase if there is any error by failing the reconcile instead of getting stucked

@travisn travisn merged commit df958b3 into rook:master Nov 26, 2024
55 checks passed
This was referenced Nov 26, 2024
Merged
Merged
subhamkrai added a commit that referenced this pull request Nov 27, 2024
@subhamkrai
Merge pull request #15070 from rook/mergify/bp/release-1.16/pr-15051
33c2b14 
rbdmirror: rbd import cmd stuck forever (backport #15051)
travisn added a commit that referenced this pull request Dec 6, 2024
@travisn
Merge pull request #15069 from rook/mergify/bp/release-1.15/pr-15051
b23e62f 
rbdmirror: rbd import cmd stuck forever (backport #15051)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travisn travisn travisn approved these changes

@sp98 sp98 Awaiting requested review from sp98

Assignees
No one assigned
Labels
backport-release-1.15 backport-release-1.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parth-gr @sp98 @travisn