csi: update groupsnapshot container arg #15037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
force-pushed
the
update-groupsnapshot-featuregate
branch
2 times, most recently
from
d200876 to
a63873b
Compare
travisn
requested changes
Nov 21, 2024
There was a problem hiding this comment.
The CI is failing on the snapshotting, for example:
ceph_base_file_test.go:185:
Error Trace: /home/runner/work/rook/rook/tests/integration/ceph_base_file_test.go:185
/home/runner/work/rook/rook/tests/integration/ceph_base_nfs_test.go:54
/home/runner/work/rook/rook/tests/integration/ceph_smoke_test.go:113
Error: Received unexpected error:
giving up waiting for "fs-pvc-snapshot" snapshot in namespace "default"
Test: TestCephSmokeSuite/TestCephNFS_SmokeTest
|
@travisn i will revist this PR once we have the external-snapshotter release. This is place holder PR for now for the update |
|
This pull request has merge conflicts that must be resolved before it can be merged. @Madhu-1 please rebase it. https://rook.io/docs/rook/latest/Contributing/development-flow/#updating-your-fork |
6 tasks
6 tasks
Madhu-1
force-pushed
the
update-groupsnapshot-featuregate
branch
from
2f1030a to
ab6e305
Compare
travisn
reviewed
Dec 11, 2024
6 tasks
updating the groupsnapshot to betav1 api. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
With new version of external snapshotter we dont need extra RBAC permission to create the volumesnapshot and volumesnapshotcontent Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updating the VGS document to match the betav1 API. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1
force-pushed
the
update-groupsnapshot-featuregate
branch
from
ab6e305 to
d65c62e
Compare
6 tasks
travisn
approved these changes
Jan 2, 2025
6 tasks
travisn
added a commit
that referenced
this pull request
Jan 2, 2025
csi: update groupsnapshot container arg (backport #15037)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In external-snapshotter the groupsnapshot feature flag is moved to a new container argument and the old enable-volumegroup-snapshot flag is removed, This PR updates the flag to use external-snapshotter latest version,
Note:- As the flag is removed with Rook the user cannot test/use the older version of external-snapshotter for groupsnapshot feature, but all other features will be still supported with older releases.
Checklist:
Note:- Still keeping this in pending state and will revisit this once we have external-snapshotter next release