csi: Remove version check for k8s and cephcsi #14942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version checks for the csi driver are removed now since they are all obsolete. The K8s version and cephcsi versions are no longer checked. Anyway, the move to the csi operator would take ownership of version checks needed in the future, so for now we simplify rook deployment of the csi driver. Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
Madhu-1
approved these changes
Oct 31, 2024
6 tasks
travisn
added a commit
that referenced
this pull request
Nov 1, 2024
csi: Remove version check for k8s and cephcsi (backport #14942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version checks for the csi driver are removed now since they are all obsolete. The K8s version and cephcsi versions are no longer checked. Anyway, the move to the csi operator would take ownership of version checks needed in the future, so for now we simplify rook deployment of the csi driver.
We had some discussion about making this change recently with the csi team, though I'm not finding it in an issue.
This is done now to simplify #14941 so there won't be a need to unnecessarily set the resources on the csi detection job.
Checklist: